SeanOMik
/
lyra-engine
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #19: Lua crashes when spawning entities in optimized builds #27

Merged
SeanOMik merged 4 commits from fix/scripting-switch-to-mlua into main 2024-09-30 01:39:40 +00:00
Conversation 0 Commits 4 Files Changed 30 +964 -1682
SeanOMik commented 2024-09-30 01:38:32 +00:00
Owner
Copy Link

See #19

See #19
SeanOMik added 4 commits 2024-09-30 01:38:33 +00:00
8fb686b7fe
scripting: switch to mlua, scripts need to be tested and fixed 
currently the lua-scripting example doesnt work. For some reason the userdata's metatable is a boolean...
CI / build (pull_request) Failing after 3m35s Details
ef2b0bf326
ecs,scripting: fix invalid resources being passed to lua 
The issue was World::get_resource_ptr, it was returning a pointer to the AtomicRefCell instead of the actual resource data
SeanOMik added the
Kind/Bug
Priority
High
 labels 2024-09-30 01:38:47 +00:00
SeanOMik merged commit 958c86cf73 into main 2024-09-30 01:39:40 +00:00
SeanOMik deleted branch fix/scripting-switch-to-mlua 2024-09-30 01:39:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SeanOMik/lyra-engine#27
No description provided.
Delete Branch "fix/scripting-switch-to-mlua"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?