SeanOMik
/
lyra-engine
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Global transforms #11

New Issue
Closed
opened 2024-04-02 10:29:33 -04:00 by SeanOMik · 3 comments
SeanOMik commented 2024-04-02 10:29:33 -04:00
Owner
Copy Link

The ECS has relationships now, meaning that global transforms can be implemented.

  • GlobalTransform component
  • update_global_transforms system that updates global transforms for children of entities.

Global transforms for entities will make it easier to collect the world transforms for entities, especially ones inSceneGraphs (which have a ecs world backing it.

The ECS has relationships now, meaning that global transforms can be implemented. * GlobalTransform component * `update_global_transforms` system that updates global transforms for children of entities. Global transforms for entities will make it easier to collect the world transforms for entities, especially ones in`SceneGraphs` (which have a ecs world backing it.
SeanOMik added the
Kind/Enhancement
 label 2024-04-02 10:29:33 -04:00
SeanOMik commented 2024-04-11 00:07:54 -04:00
Author
Owner
Copy Link

I implemented this as WorldTransforms. I haven't fixed lyra-resource or lyra-game to use these new changes yet but will soon. When testing the update system I discovered a bug in the ECS and it took me way too long to track it down. I did find it eventually, fixing it in commit 4162150c5f; the problem was such a stupid mistake.

I implemented this as [WorldTransform](https://git.seanomik.net/SeanOMik/lyra-engine/src/commit/60ec62c55828a4ea273a10e5614e7cc589b005cf/lyra-scene/src/world_transform.rs#L15)s. I haven't fixed `lyra-resource` or `lyra-game` to use these new changes yet but will soon. When testing the update system I discovered a bug in the ECS and it took me way too long to track it down. I did find it eventually, fixing it in commit [4162150c5f](https://git.seanomik.net/SeanOMik/lyra-engine/commit/4162150c5fd20b31eaa80904a933c5cc03d26225); the problem was such a stupid mistake.
SeanOMik commented 2024-04-17 20:48:04 -04:00
Author
Owner
Copy Link

This is now implemented. The only issue is that entities inside the SceneGraph's backing world do not have interpolated transforms. Additionally, the system_update_world_transforms system for updating transforms is manually ran by the renderer for the scene's world.

This is now implemented. The only issue is that entities inside the `SceneGraph`'s backing world do not have interpolated transforms. Additionally, the `system_update_world_transforms` system for updating transforms is manually ran by the renderer for the scene's world.
SeanOMik commented 2024-04-18 22:29:35 -04:00
Author
Owner
Copy Link

#12 tracks the issue with transforms for entities in a SceneGraph not being interpolated

#12 tracks the issue with transforms for entities in a `SceneGraph` not being interpolated
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
chore/winit-wgpu-update
feat/shadow-maps
debug/sig-abort
feature/scene-as-ecs
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SeanOMik/lyra-engine#11
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?