Remove timestamp from error output, allow min/max file count value of 0

This commit is contained in:
Seednode 2023-10-03 15:00:32 -05:00
parent 97f5bddafa
commit 5dc218c60e
4 changed files with 45 additions and 46 deletions

View File

@ -17,7 +17,7 @@ import (
var ( var (
ErrInvalidFileCountRange = errors.New("maximum file count limit must be greater than or equal to minimum file count limit") ErrInvalidFileCountRange = errors.New("maximum file count limit must be greater than or equal to minimum file count limit")
ErrInvalidFileCountValue = errors.New("file count limits must be positive integers no greater than 2147483647") ErrInvalidFileCountValue = errors.New("file count limits must be non-negative integers no greater than 2147483647")
ErrInvalidPort = errors.New("listen port must be an integer between 1 and 65535 inclusive") ErrInvalidPort = errors.New("listen port must be an integer between 1 and 65535 inclusive")
ErrNoMediaFound = errors.New("no supported media formats found which match all criteria") ErrNoMediaFound = errors.New("no supported media formats found which match all criteria")
) )

View File

@ -7,6 +7,7 @@ package cmd
import ( import (
"errors" "errors"
"fmt" "fmt"
"io/fs"
"math/big" "math/big"
"regexp" "regexp"
@ -229,8 +230,6 @@ func hasSupportedFiles(path string, formats *types.Types) (bool, error) {
} }
func walkPath(path string, fileChannel chan<- string, stats *scanStatsChannels, formats *types.Types) error { func walkPath(path string, fileChannel chan<- string, stats *scanStatsChannels, formats *types.Types) error {
var wg sync.WaitGroup
errorChannel := make(chan error) errorChannel := make(chan error)
done := make(chan bool, 1) done := make(chan bool, 1)
@ -239,8 +238,7 @@ func walkPath(path string, fileChannel chan<- string, stats *scanStatsChannels,
return err return err
} }
var directories = 0 var directories, files = 0, 0
var files = 0
for _, node := range nodes { for _, node := range nodes {
if node.IsDir() { if node.IsDir() {
@ -261,31 +259,28 @@ func walkPath(path string, fileChannel chan<- string, stats *scanStatsChannels,
skipFiles = true skipFiles = true
} }
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
for _, node := range nodes { for _, node := range nodes {
wg.Add(1)
go func(node fs.DirEntry) {
defer wg.Done()
fullPath := filepath.Join(path, node.Name()) fullPath := filepath.Join(path, node.Name())
switch { switch {
case node.IsDir() && Recursive: case node.IsDir() && Recursive:
wg.Add(1)
go func() {
defer func() {
wg.Done()
}()
err := walkPath(fullPath, fileChannel, stats, formats) err := walkPath(fullPath, fileChannel, stats, formats)
if err != nil { if err != nil {
errorChannel <- err errorChannel <- err
return return
} }
}()
case !node.IsDir() && !skipFiles: case !node.IsDir() && !skipFiles:
wg.Add(1)
go func() {
defer func() {
wg.Done()
}()
path, err := normalizePath(fullPath) path, err := normalizePath(fullPath)
if err != nil { if err != nil {
errorChannel <- err errorChannel <- err
@ -302,9 +297,10 @@ func walkPath(path string, fileChannel chan<- string, stats *scanStatsChannels,
} }
stats.filesSkipped <- 1 stats.filesSkipped <- 1
}
}(node)
}
}() }()
}
}
go func() { go func() {
wg.Wait() wg.Wait()

View File

@ -12,7 +12,7 @@ import (
) )
const ( const (
ReleaseVersion string = "2.3.2" ReleaseVersion string = "2.4.0"
) )
var ( var (
@ -52,7 +52,7 @@ var (
Args: cobra.MinimumNArgs(1), Args: cobra.MinimumNArgs(1),
PreRunE: func(cmd *cobra.Command, args []string) error { PreRunE: func(cmd *cobra.Command, args []string) error {
switch { switch {
case MaxFileCount < 1 || MinFileCount < 1 || MaxFileCount > math.MaxInt32 || MinFileCount > math.MaxInt32: case MaxFileCount < 0 || MinFileCount < 0 || MaxFileCount > math.MaxInt32 || MinFileCount > math.MaxInt32:
return ErrInvalidFileCountValue return ErrInvalidFileCountValue
case MinFileCount > MaxFileCount: case MinFileCount > MaxFileCount:
return ErrInvalidFileCountRange return ErrInvalidFileCountRange
@ -97,7 +97,7 @@ func init() {
rootCmd.Flags().StringVar(&IndexFile, "index-file", "", "path to optional persistent index file") rootCmd.Flags().StringVar(&IndexFile, "index-file", "", "path to optional persistent index file")
rootCmd.Flags().BoolVarP(&Info, "info", "i", false, "expose informational endpoints") rootCmd.Flags().BoolVarP(&Info, "info", "i", false, "expose informational endpoints")
rootCmd.Flags().IntVar(&MaxFileCount, "max-file-count", math.MaxInt32, "skip directories with file counts above this value") rootCmd.Flags().IntVar(&MaxFileCount, "max-file-count", math.MaxInt32, "skip directories with file counts above this value")
rootCmd.Flags().IntVar(&MinFileCount, "min-file-count", 1, "skip directories with file counts below this value") rootCmd.Flags().IntVar(&MinFileCount, "min-file-count", 0, "skip directories with file counts below this value")
rootCmd.Flags().IntVar(&PageLength, "page-length", 0, "pagination length for info pages") rootCmd.Flags().IntVar(&PageLength, "page-length", 0, "pagination length for info pages")
rootCmd.Flags().IntVarP(&Port, "port", "p", 8080, "port to listen on") rootCmd.Flags().IntVarP(&Port, "port", "p", 8080, "port to listen on")
rootCmd.Flags().StringVar(&Prefix, "prefix", "/", "root path for http handlers (for reverse proxying)") rootCmd.Flags().StringVar(&Prefix, "prefix", "/", "root path for http handlers (for reverse proxying)")

View File

@ -10,6 +10,7 @@ import (
"errors" "errors"
"fmt" "fmt"
"io" "io"
"log"
"net" "net"
"net/http" "net/http"
"os" "os"
@ -404,6 +405,8 @@ func redirectRoot() httprouter.Handle {
} }
func ServePage(args []string) error { func ServePage(args []string) error {
log.SetFlags(0)
timeZone := os.Getenv("TZ") timeZone := os.Getenv("TZ")
if timeZone != "" { if timeZone != "" {
var err error var err error