SeanOMik
/
libki
mirror of https://github.com/SeanOMik/libki.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: Session::send_packet was unnecessarily templated

This commit is contained in:
Joshua Scott 2018-04-11 01:12:53 +01:00
parent 599afed56f
commit c4630ae970
2 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
include/ki/protocol/net/Session.h
View File

@ -31,23 +31,10 @@ namespace net
uint16_t get_latency() const;
bool is_alive() const;
void send_packet(bool is_control, control::Opcode opcode,
const util::Serializable &data);
protected:
template <typename DataT>
void send_packet(const bool is_control, const control::Opcode opcode,
const DataT &data)
{
static_assert(std::is_base_of<util::Serializable, DataT>::value,
"DataT must inherit Serializable.");
std::ostringstream ss;
PacketHeader header(is_control, (uint8_t)opcode);
header.write_to(ss);
data.write_to(ss);
const auto buffer = ss.str();
send_data(buffer.c_str(), buffer.length());
}
template <typename DataT>
DataT read_data()
{

12
src/protocol/net/Session.cpp
View File

@ -60,6 +60,18 @@ namespace net
).count() <= 10;
}
void Session::send_packet(const bool is_control, const control::Opcode opcode,
const util::Serializable& data)
{
std::ostringstream ss;
PacketHeader header(is_control, (uint8_t)opcode);
header.write_to(ss);
data.write_to(ss);
const auto buffer = ss.str();
send_data(buffer.c_str(), buffer.length());
}
void Session::on_connected()
{
// If this is the server-side of a Session