SeanOMik
/
libki
mirror of https://github.com/SeanOMik/libki.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

protocol: Fix memory leak in Packet when data isn't read succesfully

This commit is contained in:
Joshua Scott 2018-04-06 04:52:58 +01:00
parent f2247f03f4
commit a13731ccc0
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/ki/protocol/Packet.h
View File

@ -1,5 +1,6 @@
#pragma once #pragma once
#include "../util/Serializable.h" #include "../util/Serializable.h"
#include "exception.h"
#include <cstdint> #include <cstdint>
#include <vector> #include <vector>
#include <sstream> #include <sstream>
@ -41,7 +42,15 @@ namespace protocol
std::istringstream iss(std::string(m_payload.data(), m_payload.size())); std::istringstream iss(std::string(m_payload.data(), m_payload.size()));
DataT *data = new DataT(); DataT *data = new DataT();
try
{
data->read_from(iss); data->read_from(iss);
}
catch (parse_error &e)
{
delete data;
throw;
}
return data; return data;
} }