From 7181c49bfb2887246e540c3f6290f6a6a4591334 Mon Sep 17 00:00:00 2001
From: Joshua Scott <joshsoragaming@gmail.com>
Date: Tue, 11 Dec 2018 15:47:37 +0000
Subject: [PATCH] test: Add properties to slightly improve serialization
 coverage

---
 test/samples/serialization_binary_file.bin    | Bin 365 -> 1229 bytes
 test/samples/serialization_binary_regular.bin | Bin 161 -> 985 bytes
 test/src/unit-serialization.cpp               |  49 +++++++++++++++++-
 3 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/test/samples/serialization_binary_file.bin b/test/samples/serialization_binary_file.bin
index a97f44b2095efda94d66ff7d225fd419d5b35fec..c67b1ef3c42582dd738d1da0c30c9ebdb2c1b93d 100644
GIT binary patch
literal 1229
zcmeIx-AmI^9LMqR9^IyMo6cHh`ZIelYxZoGJ#4mC+Jl*^tY-e^94YN0*d|0HMo@H9
zh=z0(1`@0?iY|g(2}V~z(Pdq<5Q69;@9U!Xsrf&2(b#L>&pC(hkMTR_7(}GMy6;-^
zI*}0h&FA~sZnMbqJF~XlBTPJ*oXZ+c5*)WZH6~*}>Dx@+Wwn@f;`OJGT@JggEJwCl
z-nyzhZdawVqFi-GjW^o<bS?xl!M~kaM@B1k-ZHrTOPxO+dMB1T7wLRd|1sm0$jE3)
z;~Ue`iBwt}izPFOaf3)<abcEK8Ie&*iB|fJk<yZ2CQTZXm?R~`Sm$|PuY73#<mw9K
z$X^D=XMFxp<Y%KjFwMBfIdoHGE+~@j^gg>3(3!iN8E)7?&0%7G@~V;QMG?7tG+78;
z4(G@^Uf3V_45j?O>D4?@iWMTYFTW2Cs{tRiuAX56?^Z0Zq6{|J;XpZP6(=g;f*T%G
zp&IIc)L<Ew!-o~9#Y)s+73$Fd4UJfhCal3)u-~#C&DekzY{Vw`(TdI3g00ww?NIM!
zC)%(J?bwYy=)hj=!+sn<06}!(AVN5VFb+eVlrD7RD30McPM`<s==I_h`VhfsoWWVB
z19=YTaRE^b;35X0BZeWwq4wro%f0yjz4`a{MqQG;>DLrR3g&pYNY$b4n3_|$wQf4A
Q?n>cxJe;HIQ0pe@Z|1Xyk^lez

delta 76
zcmX@h`Id=`k%56BLO8fugL@+vJL6<sMh%k%K(Up~f2J`3rFO9-yEOpm1R&nXIZpyC
Lb_7+787Kz;lr0c3

diff --git a/test/samples/serialization_binary_regular.bin b/test/samples/serialization_binary_regular.bin
index 92c342e884a40a16bd844cf4ba6bf047a520c53c..079bd66d6c0f879c5cb9a6b68e9a62e36bcf0f31 100644
GIT binary patch
literal 985
zcmeIxM^ZvT5P;z(NK~?l`C(3&a|Fbvm=#pS_(V!5-SJ@Kojd?57v937xbc6bJ1^kE
zsrjaRdKObtU6T!_Uvegk*;Z$DIUV+Z-{<u-)VqIILXs(#$_i6c^g>xzs@ij<KvjxT
zlCmg2t45|vfr?I66-}O{!v4dXiiM-e%xA<I6M2h^=!wwlV{Ar5%m|^Dd{RwBV?2BZ
zG4{r}1y<C-20I*Z!UZ?#(Ety;@WGD&f-vrAL=&13MhjZehIVwI6J1acK{tBPi$3&Y
z0D~C9Fh($nD8?|32~1)N(=gsTi#g0=0gG6|GFGsPHLN3sI1<=E5}Q!5g>9s;gI(-l
z9|t(Z5sq<!G%`5F8P1W#1#-B=6|QlETiijzJ@WYP$=~aVnZDGldDV!<Kd8OuRSWS8
Dbk{{#

delta 39
kcmcb~zL0T3qrxtiY&S**2w(zIyI7Ll!1R%1H)bFo0J^6K`2YX_

diff --git a/test/src/unit-serialization.cpp b/test/src/unit-serialization.cpp
index 83f25b2..24c4995 100644
--- a/test/src/unit-serialization.cpp
+++ b/test/src/unit-serialization.cpp
@@ -146,9 +146,22 @@ DERIVED_PCLASS(NestedTestObjectA, NestedTestObject)
 {
 public:
 	DERIVED_PCLASS_CONSTRUCTOR(NestedTestObjectA, NestedTestObject)
+		INIT_PROPERTY(extra_value, "int")
 	{
 		m_kind = NestedObjectKind::OBJECT_A;
+		extra_value = 10;
 	}
+
+	NestedTestObjectA &operator=(const NestedTestObjectA &that)
+	{
+		m_kind.get() = that.m_kind.get();
+		extra_value.get() = that.extra_value.get();
+		return *this;
+	}
+
+	// Define an extra property so that we have something to validate this object
+	// more specifically.
+	pclass::StaticProperty<int> extra_value;
 };
 
 /**
@@ -190,8 +203,12 @@ public:
 		INIT_PROPERTY(float32, "float")
 		INIT_PROPERTY(float64, "double")
 		INIT_PROPERTY(vector3d, "struct Vector3D")
+		INIT_PROPERTY(int_ptr, "int")
+		INIT_PROPERTY(value_object, "class NestedTestObjectA")
 		INIT_PROPERTY(not_null_object, "class NestedTestObject")
 		INIT_PROPERTY(null_object, "class NestedTestObject")
+		INIT_PROPERTY(collection, "int")
+		INIT_PROPERTY(ptr_collection, "int")
 		INIT_PROPERTY(objects, "class NestedTestObject")
 	{}
 
@@ -222,10 +239,18 @@ public:
 	// Test writing custom defined primitives
 	pclass::StaticProperty<Vector3D> vector3d;
 
+	// Test dereferencing when writing pointers to primitives
+	pclass::StaticProperty<int *> int_ptr;
+
 	// Test writing a single instance of another object
+	pclass::StaticProperty<NestedTestObjectA> value_object;
 	pclass::StaticProperty<NestedTestObject *> not_null_object;
 	pclass::StaticProperty<NestedTestObject *> null_object;
 
+	// Test writing collections of primitives
+	pclass::VectorProperty<int> collection;
+	pclass::VectorProperty<int *> ptr_collection;
+
 	// Test writing multiple instances of another object
 	pclass::VectorProperty<NestedTestObject *> objects;
 };
@@ -272,6 +297,9 @@ void define_types()
 #define EXPECTED_float32 3.1415927410125732421875f
 #define EXPECTED_float64 3.141592653589793115997963468544185161590576171875
 #define EXPECTED_vector3d Vector3D(24.0f, 61.0f, 3.62f)
+#define EXPECTED_int_ptr 52
+#define EXPECTED_value_object_extra_value 20
+#define EXPECTED_collection_size 100
 #define SET_EXPECTED(object, identifier) object.identifier = EXPECTED_##identifier
 #define IS_EXPECTED(object, identifier) object.identifier.get() == EXPECTED_##identifier
 
@@ -298,8 +326,17 @@ void configure_test_object(TestObject &object)
 	SET_EXPECTED(object, float32);
 	SET_EXPECTED(object, float64);
 	SET_EXPECTED(object, vector3d);
+	object.int_ptr = new int(EXPECTED_int_ptr);
 	
+	// Configure the collection of integers
+	for (auto i = 0; i < EXPECTED_collection_size; ++i)
+	{
+		object.collection.push_back(i);
+		object.ptr_collection.push_back(new int(i));
+	}
+
 	// Configure nested objects
+	object.value_object.get().extra_value = EXPECTED_value_object_extra_value;
 	object.not_null_object = g_type_system->instantiate<NestedTestObject>("class NestedTestObject");
 	object.null_object = nullptr;
 	object.objects.push_back(
@@ -333,8 +370,19 @@ void validate_test_object(TestObject &object)
 	REQUIRE(IS_EXPECTED(object, float32));
 	REQUIRE(IS_EXPECTED(object, float64));
 	REQUIRE(IS_EXPECTED(object, vector3d));
+	REQUIRE(*object.int_ptr == EXPECTED_int_ptr);
+
+	// Validate both collections
+	REQUIRE(object.collection.size() == EXPECTED_collection_size);
+	REQUIRE(object.ptr_collection.size() == EXPECTED_collection_size);
+	for (auto i = 0; i < EXPECTED_collection_size; i++)
+	{
+		REQUIRE(object.collection[i] == i);
+		REQUIRE(*object.ptr_collection[i] == i);
+	}
 
 	// Validate nested objects
+	REQUIRE(object.value_object.get().extra_value == EXPECTED_value_object_extra_value);
 	REQUIRE(object.not_null_object.get() != nullptr);
 	REQUIRE(object.not_null_object.get()->get_kind() == NestedObjectKind::OBJECT);
 	REQUIRE(object.null_object.get() == nullptr);
@@ -387,7 +435,6 @@ void test_serializer(
 
 		// Validate the contents of the stream
 		const auto stream_size = (end_pos - start_pos).as_bytes();
-
 		REQUIRE(stream_size == sample_size);
 		auto *stream_data = new uint8_t[stream_size];
 		stream.seek(start_pos);