From 74b2f99dc7de5f44a49bdf5f1409b039dd59daf7 Mon Sep 17 00:00:00 2001
From: SeanOMik <seanomik@gmail.com>
Date: Sun, 6 Aug 2023 19:13:47 -0400
Subject: [PATCH] chore: update zfs dashboard

---
 .../monitoring/zfs-exporter/dashboard.yaml    | 110 ++++--------------
 1 file changed, 22 insertions(+), 88 deletions(-)

diff --git a/cluster/apps/monitoring/zfs-exporter/dashboard.yaml b/cluster/apps/monitoring/zfs-exporter/dashboard.yaml
index 91e30e9..87352c1 100644
--- a/cluster/apps/monitoring/zfs-exporter/dashboard.yaml
+++ b/cluster/apps/monitoring/zfs-exporter/dashboard.yaml
@@ -239,6 +239,8 @@ data:
                 "mode": "thresholds"
               },
               "mappings": [],
+              "max": 100,
+              "min": 0,
               "thresholds": {
                 "mode": "absolute",
                 "steps": [
@@ -246,26 +248,28 @@ data:
                     "color": "green",
                     "value": null
                   },
+                  {
+                    "color": "#EAB839",
+                    "value": 60
+                  },
                   {
                     "color": "red",
-                    "value": 1
+                    "value": 70
                   }
                 ]
-              }
+              },
+              "unit": "percent"
             },
             "overrides": []
           },
           "gridPos": {
             "h": 6,
-            "w": 2,
+            "w": 3,
             "x": 6,
             "y": 0
           },
-          "id": 6,
+          "id": 25,
           "options": {
-            "colorMode": "value",
-            "graphMode": "area",
-            "justifyMode": "auto",
             "orientation": "auto",
             "reduceOptions": {
               "calcs": [
@@ -274,7 +278,8 @@ data:
               "fields": "",
               "values": false
             },
-            "textMode": "auto"
+            "showThresholdLabels": false,
+            "showThresholdMarkers": true
           },
           "pluginVersion": "9.5.3",
           "targets": [
@@ -284,17 +289,14 @@ data:
                 "uid": "${DS_VICTORIA}"
               },
               "editorMode": "code",
-              "exemplar": false,
-              "expr": "sum(zfs_read_errors{device_type=\"pool\",device_name=~\"$viewingPool\"})",
-              "format": "time_series",
-              "instant": false,
+              "expr": "zfs_fragmentation{pool=\"$viewingPool\", device_type=\"pool\"}",
               "legendFormat": "__auto",
               "range": true,
               "refId": "A"
             }
           ],
-          "title": "Pool Read Errors",
-          "type": "stat"
+          "title": "Pool Fragmentation",
+          "type": "gauge"
         },
         {
           "datasource": {
@@ -325,76 +327,8 @@ data:
           },
           "gridPos": {
             "h": 6,
-            "w": 2,
-            "x": 8,
-            "y": 0
-          },
-          "id": 23,
-          "options": {
-            "colorMode": "value",
-            "graphMode": "area",
-            "justifyMode": "auto",
-            "orientation": "auto",
-            "reduceOptions": {
-              "calcs": [
-                "lastNotNull"
-              ],
-              "fields": "",
-              "values": false
-            },
-            "textMode": "auto"
-          },
-          "pluginVersion": "9.5.3",
-          "targets": [
-            {
-              "datasource": {
-                "type": "prometheus",
-                "uid": "${DS_VICTORIA}"
-              },
-              "editorMode": "code",
-              "exemplar": false,
-              "expr": "sum(zfs_write_errors{device_name=\"$viewingPool\", device_type=\"pool\"})",
-              "format": "time_series",
-              "instant": false,
-              "legendFormat": "__auto",
-              "range": true,
-              "refId": "A"
-            }
-          ],
-          "title": "Pool Write Errors",
-          "type": "stat"
-        },
-        {
-          "datasource": {
-            "type": "prometheus",
-            "uid": "${DS_VICTORIA}"
-          },
-          "fieldConfig": {
-            "defaults": {
-              "color": {
-                "mode": "thresholds"
-              },
-              "mappings": [],
-              "thresholds": {
-                "mode": "absolute",
-                "steps": [
-                  {
-                    "color": "green",
-                    "value": null
-                  },
-                  {
-                    "color": "red",
-                    "value": 1
-                  }
-                ]
-              }
-            },
-            "overrides": []
-          },
-          "gridPos": {
-            "h": 6,
-            "w": 2,
-            "x": 10,
+            "w": 3,
+            "x": 9,
             "y": 0
           },
           "id": 24,
@@ -421,7 +355,7 @@ data:
               },
               "editorMode": "code",
               "exemplar": false,
-              "expr": "sum(zfs_checksum_errors{device_name=\"$viewingPool\", device_type=\"pool\"})",
+              "expr": "sum(zfs_checksum_errors{device_name=\"$viewingPool\", device_type=\"pool\"}) + sum(zfs_write_errors{device_name=\"$viewingPool\", device_type=\"pool\"}) + sum(zfs_read_errors{device_type=\"pool\",device_name=~\"$viewingPool\"})",
               "format": "time_series",
               "instant": false,
               "legendFormat": "__auto",
@@ -429,7 +363,7 @@ data:
               "refId": "A"
             }
           ],
-          "title": "Pool Checksum Errors",
+          "title": "Pool Total Errors",
           "type": "stat"
         },
         {
@@ -1397,13 +1331,13 @@ data:
         ]
       },
       "time": {
-        "from": "now-6h",
+        "from": "now-15m",
         "to": "now"
       },
       "timepicker": {},
       "timezone": "",
       "title": "ZFS Dashboard",
       "uid": "2GaZi3hVk",
-      "version": 2,
+      "version": 3,
       "weekStart": ""
     }
\ No newline at end of file